Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add published_date field to experiment schema #5936

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

jeddai
Copy link
Member

@jeddai jeddai commented Nov 21, 2023

O(n) change

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

Copy link

@eliserichards eliserichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 🚀

@jeddai jeddai force-pushed the add-published-date-to-nimbus-schema branch from adc44e7 to 862a008 Compare November 22, 2023 18:05
Copy link
Contributor

@jhugman jhugman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc. Nice!

components/nimbus/src/enrollment.rs Outdated Show resolved Hide resolved
components/nimbus/src/tests/helpers.rs Outdated Show resolved Hide resolved
components/nimbus/src/tests/test_enrollment.rs Outdated Show resolved Hide resolved
components/nimbus/src/enrollment.rs Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aa5572f) 26.09% compared to head (862a008) 26.18%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5936      +/-   ##
==========================================
+ Coverage   26.09%   26.18%   +0.09%     
==========================================
  Files         375      375              
  Lines       47292    47335      +43     
==========================================
+ Hits        12339    12397      +58     
+ Misses      34953    34938      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeddai jeddai force-pushed the add-published-date-to-nimbus-schema branch from 862a008 to dc94e35 Compare November 29, 2023 15:13
@jeddai jeddai added this pull request to the merge queue Nov 29, 2023
Merged via the queue into mozilla:main with commit bd59b3c Nov 29, 2023
16 checks passed
@jeddai jeddai deleted the add-published-date-to-nimbus-schema branch November 29, 2023 20:38
@jeddai jeddai added the O(n) Well-scoped logic changes label Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O(n) Well-scoped logic changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants