Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading UniFFI to 0.25.1 #5912

Closed
wants to merge 1 commit into from
Closed

Upgrading UniFFI to 0.25.1 #5912

wants to merge 1 commit into from

Conversation

bendk
Copy link
Contributor

@bendk bendk commented Nov 9, 2023

do not merge because I think this should wait until Glean also updates to 0.25.1

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (64033af) 25.85% compared to head (bf7797d) 19.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5912      +/-   ##
==========================================
- Coverage   25.85%   19.08%   -6.78%     
==========================================
  Files         375      364      -11     
  Lines       47754    44928    -2826     
==========================================
- Hits        12349     8574    -3775     
- Misses      35405    36354     +949     

see 30 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Mostly mechanical, the one extra step was to add the `serde::derive`
feature to `remote_settings`.  I guess it's not pulling that feature in
from `uniffi` anymore.
@badboy badboy changed the title Upgarding UniFFI to 0.25.1 Upgrading UniFFI to 0.25.1 Nov 10, 2023
@bendk bendk closed this Nov 22, 2023
@bendk bendk deleted the uniffi-0.25.1 branch November 22, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants