-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add enrollment status metric for cirrus #5891
add enrollment status metric for cirrus #5891
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5891 +/- ##
==========================================
+ Coverage 36.45% 36.66% +0.20%
==========================================
Files 348 348
Lines 33604 33677 +73
==========================================
+ Hits 12252 12349 +97
+ Misses 21352 21328 -24
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking just fine. I'm approving this, though you should address the nits that I've raised.
@brennie have you any reason for this not to be r+wc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant to approve this last time but forgot to tick the box. 😅😅
af1748b
to
50dfb5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
50dfb5e
to
b3ac38c
Compare
Pull Request checklist
[ci full]
to the PR title.Branch builds: add
[firefox-android: branch-name]
to the PR title.