Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No issue: Fix typo in FML #5888

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

eliserichards
Copy link

We were spelling "highlight" with an extra "t" 😄

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

@eliserichards eliserichards requested a review from jhugman October 25, 2023 20:14
Copy link
Contributor

@jhugman jhugman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh perfect, thank you!

@codecov-commenter
Copy link

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (ecef2d4) 36.67% compared to head (0693727) 36.67%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5888   +/-   ##
=======================================
  Coverage   36.67%   36.67%           
=======================================
  Files         348      348           
  Lines       33607    33607           
=======================================
  Hits        12324    12324           
  Misses      21283    21283           
Files Coverage Δ
...ponents/support/nimbus-fml/src/client/inspector.rs 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eliserichards eliserichards added this pull request to the merge queue Oct 26, 2023
Merged via the queue into mozilla:main with commit c82bccf Oct 26, 2023
16 checks passed
@eliserichards eliserichards deleted the fix-typo branch October 26, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants