Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYNC-3518] Add requirements.txt for automation directory #5855

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

ylogx
Copy link
Contributor

@ylogx ylogx commented Oct 4, 2023

Changes

  • Adds the missing requirements.txt with the required dependencies for automation directory
  • Adds dependency installation instructions in the relevant documentations

Impact

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

@ylogx ylogx changed the title [SYNC-3518] Add requirements.txt for automation directory #5281 [SYNC-3518] Add requirements.txt for automation directory Oct 4, 2023
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (399fe73) 36.91% compared to head (f2fc7ab) 36.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5855   +/-   ##
=======================================
  Coverage   36.91%   36.91%           
=======================================
  Files         346      346           
  Lines       33430    33430           
=======================================
  Hits        12340    12340           
  Misses      21090    21090           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ylogx ylogx force-pushed the chaudhary/issue-5281/py-requirements branch from f2fc7ab to 0c3251b Compare October 4, 2023 20:46
@tarikeshaq tarikeshaq self-requested a review October 5, 2023 14:34
Copy link
Contributor

@tarikeshaq tarikeshaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @ylogx!! 🙏

@tarikeshaq tarikeshaq added this pull request to the merge queue Oct 5, 2023
Merged via the queue into mozilla:main with commit b7cb31d Oct 5, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create requirements.txt for the automation directory
3 participants