Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linux-gnu builds for cirrus megazord [ci full] #5833

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

jhugman
Copy link
Contributor

@jhugman jhugman commented Sep 22, 2023

  • Adds linux-gnu builds for cirrus.
  • Fixes Windows build bug
  • Small refactor of create/prepare archive to make it easier to debug

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (73890de) 36.83% compared to head (d9f7681) 36.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5833      +/-   ##
==========================================
- Coverage   36.83%   36.81%   -0.03%     
==========================================
  Files         347      347              
  Lines       33501    33447      -54     
==========================================
- Hits        12340    12313      -27     
+ Misses      21161    21134      -27     

see 28 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jhugman jhugman force-pushed the jhugman/exp-3790-build-linux-megazord-on-linux2004 branch 8 times, most recently from 2845d53 to 9410af4 Compare September 25, 2023 11:25
@jhugman jhugman force-pushed the jhugman/exp-3790-build-linux-megazord-on-linux2004 branch 2 times, most recently from d6b6ff9 to c6a8903 Compare October 6, 2023 19:19
@jhugman jhugman requested a review from brennie October 6, 2023 19:20
@jhugman jhugman changed the title Use linux2004 box to build linux-gnu server megazords [ci full] Rearrange megazord archive to allow multiple targets for the same OS [ci full] Oct 6, 2023
@jhugman jhugman removed the request for review from brennie October 6, 2023 20:29
@jhugman jhugman changed the title Rearrange megazord archive to allow multiple targets for the same OS [ci full] Add linux-gnu builds for cirrus megazord [ci full] Oct 9, 2023
@jhugman jhugman requested a review from brennie October 9, 2023 11:33
taskcluster/scripts/detect-target.sh Outdated Show resolved Hide resolved
e.g. `aarch64-unknown-linux-gnu/libnimbus_experimenter.so` can now co-exist alongside `x86-unknown-linux-gnu/libnimbus_experimenter.so`.

The detect script has changed to identify the correct name and path of the shared object.
@jhugman jhugman force-pushed the jhugman/exp-3790-build-linux-megazord-on-linux2004 branch from 1ac3092 to 24f9ca1 Compare October 11, 2023 15:48
@jhugman jhugman force-pushed the jhugman/exp-3790-build-linux-megazord-on-linux2004 branch from 24f9ca1 to d9f7681 Compare October 11, 2023 15:50
@jhugman jhugman enabled auto-merge October 11, 2023 15:51
@jhugman jhugman added this pull request to the merge queue Oct 11, 2023
Merged via the queue into main with commit b7efb70 Oct 11, 2023
@jhugman jhugman deleted the jhugman/exp-3790-build-linux-megazord-on-linux2004 branch October 11, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants