Bug 1935797 - Reject updates of moz_bookmarks.type.

mozilla · Dec 10, 2024 · 5dfd0e6 · 5dfd0e6
1 parent 29b5fd0
commit 5dfd0e6
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/components/places/sql/create_shared_triggers.sql b/components/places/sql/create_shared_triggers.sql
@@ -65,6 +65,9 @@ BEGIN
     WHERE NEW.guid <> 'root________'
       AND NOT EXISTS(
           SELECT 1 FROM moz_bookmarks WHERE id = NEW.parent);
+
+    SELECT throw(format('update: old type=%d; new=%d', OLD.type, NEW.type))
+    WHERE OLD.type <> NEW.type;
 END;
 
 -- Triggers which update visit_count and last_visit_date based on historyvisits

diff --git a/components/places/src/db/schema.rs b/components/places/src/db/schema.rs
@@ -606,6 +606,23 @@ mod tests {
                 e,
             );
         }
+
+        // Changing the type of an existing item.
+        {
+            let e = conn
+                .execute(
+                    "UPDATE moz_bookmarks SET
+                        type = 3
+                     WHERE guid = 'folder_guid_'",
+                    [],
+                )
+                .expect_err("should fail to update type of bookmark");
+            assert!(
+                e.to_string().contains("update: old type=2; new=3"),
+                "Expected error, got: {:?}",
+                e,
+            );
+        }
     }
 
     fn select_simple_int(conn: &PlacesDb, stmt: &str) -> u32 {