Use the Default trait and the pretty_assertions in search selector te…

…sts. This should make it easier to see the important part of tests, and to have a better output when tests fail.
mozilla · Dec 16, 2024 · 5aec372 · 5aec372
1 parent 1b9d2eb
commit 5aec372
Show file tree

Hide file tree

Showing 6 changed files with 73 additions and 308 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/components/search/Cargo.toml b/components/search/Cargo.toml
@@ -20,3 +20,4 @@ uniffi = { version = "0.28.2", features = ["build"] }
 
 [dev-dependencies]
 once_cell = "1.18.0"
+pretty_assertions = "0.6"
diff --git a/components/search/src/configuration_types.rs b/components/search/src/configuration_types.rs
@@ -33,7 +33,7 @@ impl JSONEngineMethod {
 /// Defines an individual search engine URL. This is defined separately to
 /// `types::SearchEngineUrl` as various fields may be optional in the supplied
 /// configuration.
-#[derive(Debug, uniffi::Record, PartialEq, Deserialize, Clone)]
+#[derive(Debug, uniffi::Record, PartialEq, Deserialize, Clone, Default)]
 #[serde(rename_all = "camelCase")]
 pub(crate) struct JSONEngineUrl {
     /// The PrePath and FilePath of the URL. May include variables for engines
@@ -55,7 +55,7 @@ pub(crate) struct JSONEngineUrl {
 }
 
 /// Reflects `types::SearchEngineUrls`, but using `EngineUrl`.
-#[derive(Debug, uniffi::Record, PartialEq, Deserialize, Clone)]
+#[derive(Debug, uniffi::Record, PartialEq, Deserialize, Clone, Default)]
 #[serde(rename_all = "camelCase")]
 pub(crate) struct JSONEngineUrls {
     /// The URL to use for searches.
@@ -69,7 +69,7 @@ pub(crate) struct JSONEngineUrls {
 }
 
 /// Represents the engine base section of the configuration.
-#[derive(Debug, Deserialize, Clone)]
+#[derive(Debug, Default, Deserialize, Clone)]
 #[serde(rename_all = "camelCase")]
 pub(crate) struct JSONEngineBase {
     /// A list of aliases for this engine.
Original file line number	Diff line number	Diff line change
Expand Up		@@ -20,3 +20,4 @@ uniffi = { version = "0.28.2", features = ["build"] }

		[dev-dependencies]
		once_cell = "1.18.0"
		pretty_assertions = "0.6"