Skip to content

Commit

Permalink
Taskcluster fixes based on the recent issues
Browse files Browse the repository at this point in the history
One reason we didn't catch this sooner we relied posting `/taskcluster
ci full` in a GH comment, but that didn't actually run all the tasks.

- Added a set of test parameters for the github issue comment
- Run all tasks for issue comments
  • Loading branch information
bendk committed Dec 19, 2024
1 parent 35bb959 commit 10b9ce5
Show file tree
Hide file tree
Showing 4 changed files with 41 additions and 3 deletions.
2 changes: 1 addition & 1 deletion taskcluster/kinds/android-build/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ tasks:
attributes:
run-on-pr-type: all
needs-sccache: false # TODO: Bug 1623426 deal with this once we're in prod
run-on-tasks-for: [github-pull-request, cron]
run-on-tasks-for: [github-pull-request, github-issue-comment, cron]
description: Build and test (Android - linux-x86-64)
scopes:
- project:releng:services/tooltool/api/download/internal
Expand Down
2 changes: 1 addition & 1 deletion taskcluster/kinds/module-build/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ kind-dependencies:
task-defaults:
attributes:
run-on-pr-type: full-ci
run-on-tasks-for: [github-pull-request, github-push, cron]
run-on-tasks-for: [github-pull-request, github-issue-comment, github-push, cron]
description: "{module_name} - Build and test"
scopes:
- project:releng:services/tooltool/api/download/internal
Expand Down
2 changes: 1 addition & 1 deletion taskcluster/kinds/swift/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ tasks:
release-routes:
- index.project.{project}.v2.swift.{appservices_version}
needs-sccache: false # TODO: Bug 1623426 deal with this once we're in prod
run-on-tasks-for: [github-push, github-pull-request, cron]
run-on-tasks-for: [github-push, github-pull-request, github-issue-comment, cron]
description: Build and test (Swift)
scopes:
- project:releng:services/tooltool/api/download/internal
Expand Down
38 changes: 38 additions & 0 deletions taskcluster/test/params/pr-comment-ci-full.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
base_ref: origin/main
base_repository: https://github.com/mozilla/application-services
base_rev: 878a52fcc6d7945a7c10d5522d267b3f45a0dc74
branch-build: {}
build_date: 1733960430
build_number: 1
do_not_optimize: []
enable_always_target: true
existing_tasks: {}
files_changed:
- build.gradle
- gradle/libs.versions.toml
- build-scripts/component-common.gradle
- components/viaduct/android/build.gradle
- megazords/full/android/build.gradle
- publish.gradle
- gradle/libs.versions.toml
- tools/nimbus-gradle-plugin/build.gradle
filters:
- target_tasks_method
- branch-build
head_ref: push-ppkoqtrwnkmq
head_repository: https://github.com/bendk/application-services
head_rev: 0392a9dc9bf4c947766d8532175ce0014f1e29ed
head_tag: ''
level: '1'
moz_build_date: '20241211234030'
next_version: null
optimize_strategies: null
optimize_target_tasks: true
owner: [email protected]
project: application-services
pushdate: 0
pushlog_id: '0'
repository_type: git
target_tasks_method: pr-full
tasks_for: github-issue-comment
version: 135.0a1

0 comments on commit 10b9ce5

Please sign in to comment.