1982 delegate reject actions to content actions too #23023
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: mozilla/addons#15306
Depends on #23004 & needs rebasing after that is merged.
Description
Implements the last remaining actions that could need a hold for 2nd level approval - version rejections.
Context
To ease implementation, I've focused on the simple case - the initial rejection of one or more versions - so ignored auto rejections and rejections that happen via blocks (and renamed the existing
reject_multiple_versions
function). Auto rejections don't need another hold because it was already considered when the initial decision was made; blocks have their own hold criteria. Follow-up work would be to continue migrating the remaining code that changes addon/version states in the reviewer tools to their equivalent ContentActionTesting
tbd...
Checklist
#ISSUENUM
at the top of your PR to an existing open issue in the mozilla/addons repository.