Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1982 delegate reject actions to content actions too #23023

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

eviljeff
Copy link
Member

@eviljeff eviljeff commented Jan 24, 2025

Fixes: mozilla/addons#15306

Depends on #23004 & needs rebasing after that is merged.

Description

Implements the last remaining actions that could need a hold for 2nd level approval - version rejections.

Context

To ease implementation, I've focused on the simple case - the initial rejection of one or more versions - so ignored auto rejections and rejections that happen via blocks (and renamed the existing reject_multiple_versions function). Auto rejections don't need another hold because it was already considered when the initial decision was made; blocks have their own hold criteria. Follow-up work would be to continue migrating the remaining code that changes addon/version states in the reviewer tools to their equivalent ContentAction

Testing

tbd...

Checklist

  • Add #ISSUENUM at the top of your PR to an existing open issue in the mozilla/addons repository.
  • Successfully verified the change locally.
  • The change is covered by automated tests, or otherwise indicated why doing so is unnecessary/impossible.
  • Add before and after screenshots (Only for changes that impact the UI).
  • Add or update relevant docs reflecting the changes made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: delegate reject version review actions to CinderActions too
1 participant