Merge pull request #727 from mozilla/update_cloudtrail_plugin

Add responseelements lastModified in cloudtrail plugin
mozilla · Jul 23, 2018 · c26229b · c26229b
2 parents 5da4a88 + 9e05f32
commit c26229b
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/mq/plugins/cloudtrail.py b/mq/plugins/cloudtrail.py
@@ -32,6 +32,7 @@ def __init__(self):
             'details.responseelements.subnets',
             'details.responseelements.endpoint',
             'details.responseelements.securityGroups',
+            'details.responseelements.lastModified',
             'details.additionaleventdata',
             'details.serviceeventdetails',
             'details.requestparameters.disableApiTermination',

diff --git a/tests/mq/plugins/test_cloudtrail.py b/tests/mq/plugins/test_cloudtrail.py
@@ -362,6 +362,30 @@ def test_disableApiTermination(self):
         assert retmessage == expected_message
         assert retmeta == {}
 
+    def test_responseelements_lastModified(self):
+        msg = {
+            'source': 'cloudtrail',
+            'details': {
+                'responseelements': {
+                    'lastModified': 'astringvalue'
+                }
+            }
+        }
+        (retmessage, retmeta) = self.plugin.onMessage(msg, {})
+
+        expected_message = {
+            'source': 'cloudtrail',
+            'details': {
+                'responseelements': {
+                    'lastModified': {
+                        'raw_value': 'astringvalue'
+                    }
+                }
+            }
+        }
+        assert retmessage == expected_message
+        assert retmeta == {}
+
     def test_unusual(self):
         msg = {
             'source': 'cloudtrail',