Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OBS-144: Migrate from socorro-release to obs-common #6802

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

relud
Copy link
Member

@relud relud commented Nov 12, 2024

No description provided.

@relud relud requested a review from a team as a code owner November 12, 2024 18:44
Copy link
Contributor

@willkg willkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double-checked that building and running a local dev environment works. Everything looks good. 💯

@relud relud enabled auto-merge November 13, 2024 22:24
@relud relud added this pull request to the merge queue Nov 13, 2024
Merged via the queue into main with commit 9b92f64 Nov 13, 2024
1 check passed
@relud relud deleted the relud-obs-common branch November 13, 2024 23:03
@willkg
Copy link
Contributor

willkg commented Nov 20, 2024

I messed up the validation here. We didn't test processing crash reports in the local dev environment. bin/process_crashes.sh needs to be updated. Also, we missed one more reference in docs/dev.rst to socorro-cmd pubsub which no longer exists.

@relud Can you fix these two things? ^^^

@relud
Copy link
Member Author

relud commented Nov 20, 2024

fix in #6813

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants