bug-1911367: Remove processor heartbeat and process metrics #6776
Conversation
This removes processor heartbeat (and the scaffolding for that heartbeat) which generated process metrics for the processor container. We don't need those anymore--the problem those were added to help us understand is long gone now.
| @@ -76,7 +64,6 @@ def __init__( | |||
| idle_delay=7, | |||
| quit_on_empty_queue=False, | |||
| job_source_iterator=default_iterator, | |||
| heartbeat_func=default_heartbeat, | |||
There was a problem hiding this comment.
Socorro still has this TaskManager and ThreadedTaskManager which is the last remnants for how socorro service processes were structured a long long time ago.
In this PR, I removed the heartbeat function from the processor app as well as the scaffolding for heartbeats for any app that uses the task managers figuring we don't need that anymore. (We can always re-add it if we do need it.)
| @@ -109,7 +94,7 @@ def _get_iterator(self): | |||
| job_source_iterator can be one of a few things: | |||
|
|
|||
| * a class that can be instantiated and iterated over | |||
| * a function that returns an interator | |||
| * a function that returns an iterator | |||
There was a problem hiding this comment.
I set up pre-commit and it's now fixing typos.
| ) | ||
|
|
||
| except Exception as exc: | ||
| sentry_sdk.capture_exception(exc) |
There was a problem hiding this comment.
Buh-bye!
One nice thing about removing this code is that when you have the processor running in a local dev environment, it's constantly producing output to the console even when it's just sitting around which was kind of annoying and now it won't be anymore.
|
Thank you! This change will be very nice because it'll result in a lot less console output from the processor. |
This removes processor heartbeat (and the scaffolding for that heartbeat) which generated process metrics for the processor container. We don't need those anymore--the problem those were added to help us understand is long gone now.