bug-1900646: fix submitter to only consume standard queue #6635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the submitter to only consume from the standard subscription rather than from standard, priority, and reprocessing. It does it by stomping on the subscription_name settings for priority and reprocessing in the PubSubCrashQueue class. That means this will never run in AWS, but that's what our plan was anyhow.
willkg
force-pushed
the
willkg-bug-1900646-submitter-fix
branch
from
3c1201d to
522d9d7
Compare
willkg
commented
Jun 4, 2024
| @@ -244,7 +261,11 @@ def publish(self, queue, crash_ids): | |||
| try: | |||
| future.result() | |||
| except Exception: | |||
| logger.exception(f"Crashid failed to publish: {batch[i]}") | |||
| logger.exception( | |||
There was a problem hiding this comment.
This is an unrelated fix to a bad exception logging line I did earlier. Boo me.
relud
approved these changes
Jun 4, 2024
|
This PR is larger than it otherwise would have been because I had to change a bunch of things to make the submitter tests only run in gcp mode. Without those changes, it's like 50 LOC or something like that. The complexity is limited to three spots and it's easily tested. I think this is ok to keep around for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the submitter to only consume from the standard subscription rather than from standard, priority, and reprocessing.
It does it by stomping on the subscription_name settings for priority and reprocessing in the PubSubCrashQueue class. That means this will never run in AWS, but that's what our plan was anyhow.