Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove comment from metaschema that some fields are not implemented #791

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

badboy
Copy link
Contributor

@badboy badboy commented Oct 31, 2023

It seems those fields are actually in use.

Checklist for reviewer:

For glean changes:

  • Update templates/include/glean/CHANGELOG.md

For modifications to schemas in restricted namespaces (see CODEOWNERS):

@auto-assign auto-assign bot requested a review from scholtzan October 31, 2023 10:58
Copy link
Contributor

@akkomar akkomar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These fields were proposed in https://docs.google.com/document/d/1oNi-eX_IPIZa8C0h5GZnWTM0WFivZ1hPMgMMX3c3HHs/edit#heading=h.36jrolbv6nko
It hasn't been fully implemented, i.e. pipeline still parses URI to determine destination dataset so these descriptions are correct.

@badboy
Copy link
Contributor Author

badboy commented Oct 31, 2023

These fields were proposed in docs.google.com/document/d/1oNi-eX_IPIZa8C0h5GZnWTM0WFivZ1hPMgMMX3c3HHs/edit#heading=h.36jrolbv6nko It hasn't been fully implemented, i.e. pipeline still parses URI to determine destination dataset so these descriptions are correct.

Hm, I see. but they are in use by some parts though.

@badboy badboy force-pushed the remove-unimplemented-comment branch from 60eefef to e59d451 Compare October 31, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants