Skip to content

Commit

Permalink
Merge pull request #250 from mozilla-services/1426949-infobar-2-wefix…
Browse files Browse the repository at this point in the history
…edit-edition

updates buildid with new release candidates
  • Loading branch information
lonnen authored Dec 26, 2017
2 parents b1a9238 + 8fc9be4 commit f001020
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
5 changes: 1 addition & 4 deletions antenna/throttler.py
Original file line number Diff line number Diff line change
Expand Up @@ -196,10 +196,7 @@ def match_infobar_true(data):
product == 'Firefox' and
infobar == 'true' and
version.startswith(('52.', '53.', '54.', '55.', '56.', '57.', '58.', '59.')) and
# FIXME(willkg): buildid is a string that starts with a YYYYMMDD date
# so we're doing string compares. Change this to the buildid date when
# we push out fixes.
buildid < '20180401'
buildid < '20171226'
)


Expand Down
2 changes: 1 addition & 1 deletion tests/unittest/test_throttler.py
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ def test_buildid(self):
raw_crash = {
'ProductName': 'Firefox',
'SubmittedFromInfobar': 'true',
'BuildID': '20181212222554',
'BuildID': '20171226003912',
'Version': '57.0'
}
assert match_infobar_true(raw_crash) is False
Expand Down

0 comments on commit f001020

Please sign in to comment.