Cancel bitrise tasks on taskcluster cancellation #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that while it would look better to have an early return in the `finally`, we can't do that as returning from `finally` eats the exception and it doesn't get raised to the parent (which in this case would be in charge of actually cancelling the build). Skipping the log retrieval here is necessary because it would just wait for the build to finish again, defeating the point of cancelling the job.
Eijebong
force-pushed
the
cancel-bitrise-on-taskcluster-cancellation
branch
from
94091df to
1812856
Compare
jcristau
reviewed
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #971
Fixes #924
An example run: