fix: ensure 'package_name' always uses underscores #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this fix, entering 'my-package' as the project name results in a directory called 'src/my-package', which is not importable in Python. Also adds a test.
|
I'm not sure what's up with those Decision task failures, and my brain is too tired to debug right now. They don't go away even after force pushing a new revision... I'm inclined to just land anyway, it's a low risk repo and the tests pass for me locally. |
bhearsum
approved these changes
Oct 18, 2023
|
(I don't know what happened with the decision task, but the tests certainly look fine.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this fix, entering 'my-package' as the project name results in a directory called 'src/my-package', which is not importable in Python.
Also adds a test.