Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added apple docs #184

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added apple docs #184

wants to merge 1 commit into from

Conversation

hneiva
Copy link
Contributor

@hneiva hneiva commented Oct 12, 2022

No description provided.

@hneiva hneiva requested a review from escapewindow October 12, 2022 23:49
Copy link
Contributor

@escapewindow escapewindow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could land these as-is, since having some info is better than none.
I do think that we should decide who these docs are for.

If these are docs for a Relenger with access but without knowledge, these are lacking in detail and need to be more precise. We probably want to test them by having someone who has never dealt with the developer.apple.com site follow these docs step by step, without asking you or googling any questions, and see if they can come out with a successful outcome.

If these are largely for your benefit, and the general Releng use case is "ask Heitor", then these docs may be sufficient :)

@@ -0,0 +1,21 @@
Apple Developer Portal
======================
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: ideally we'd start moving to the tutorial/how-to/explanation/reference model in https://documentation.divio.com/. If we're creating an Apple section, it may be nice to link to the pages in https://github.com/mozilla-releng/scriptworker-scripts/wiki .

@@ -0,0 +1,6 @@
# Provisioning Profiles

Production profiles are used when developers want to bypass notarization.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a "their use should be discouraged" type warning?

@@ -0,0 +1,19 @@
# Apple Account User Access
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete the apple account.

## Permissions
Roles are confusing!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are a bit vague, and it may be more helpful to the general Relenger if you guide them. E.g., "For developers, check these boxes." If you don't want to document every little thing, then it may come down to "if someone asks for something out of these guidelines, then ask ____". If you don't want to be pinged about these questions, then you likely want to document the edge cases.


1. `App Managers` with `Access to Certificates, Identifiers & Profiles` are able
to issue production level certificates. We should avoid giving out this type of
access.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to my guidelines comment elsewhere, let's change this to "don't give out this type of access unless ___". Approval from a small set of informed and trusted individuals may work; alternately, an explicit checklist may work if you want to avoid pings.

1. There's a limited amount of `Apple Distribution`, `Developer ID Installer`,
`Developer ID Application`, `iOS App Development` (and possibly others) that can
be issued and valid at the same time.
**BE EXTREMELY CAREFUL WITH ISSUED CERTIFICATES.**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm a Relenger doing this for the first time, how would I be careful with them? This is a warning without enough detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants