Switch to google-auth lib for authentication (bug 1864638) #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcristau
changed the title
jcristau
force-pushed
the
google-auth
branch
2 times, most recently
from
37aff6d to
5ed8065
Compare
JohanLorenzo
approved these changes
Nov 2, 2023
|
|
||
| ### Changed | ||
| * Removed support for pushing to the Amazon store. | ||
| * Switched Google Play Store authentication to the google-auth library. The credentials now need to be passed as a json file instead of an email address and PKCS#12 file. |
Comment on lines
-40
to
-49
| 1. Some errors might happen when executing `mozapkpublisher/push_apk.py` | ||
| 1. You might have errors like | ||
| * Errors in from_p12_keyfile in oauth2client/service_account.py or | ||
| * ImportError: cannot import name `_openssl_crypt` | ||
| * `pip uninstall oauth2client` | ||
| * `pip install oauth2client==2.0.0` | ||
| * `pip install google-api-python-client==1.5.0` | ||
| 1. Symbol not found: `_BIO_new_CMS` | ||
| * `pip uninstall cryptography` | ||
| * `LDFLAGS="-L/usr/local/opt/openssl/lib" pip install cryptography --no-use-wheel` |
There was a problem hiding this comment.
Glad to see these lines gone
| 1. Execute the steps defined in the section above. | ||
| 1. Download the latest signed builds. For instance, for Fennec Nightly: `./mozapkpublisher/get_apk.py --latest-nightly` | ||
| 1. | ||
| ```sh | ||
| ./mozapkpublisher/push_apk.py --no-gp-string-update --track beta --credentials /path/to/your/googleplay/creds.p12 --service-account [email protected] x86.apk arm.apk | ||
| ./mozapkpublisher/push_apk.py --no-gp-string-update --track beta --credentials /path/to/your/googleplay/creds.json x86.apk arm.apk |
| credentials_file_name, | ||
| scopes=scope | ||
| scopes=[scope], |
Comment on lines
-28
to
-29
| CLIENT_ID = 'client' | ||
| CLIENT_SECRET = 'secret' |
There was a problem hiding this comment.
Thanks for cleaning up these unused variable. I don't remember why they were here in the first place.
There was a problem hiding this comment.
They were part of the amazon code, and should have been removed in #253.
| humanize | ||
| mozilla-version | ||
| oauth2client | ||
| pyOpenSSL # Even not imported once in mozapkpublisher, it's needed to open p12 files |
There was a problem hiding this comment.
I like this comment is not needed anymore.
gbrownmozilla
approved these changes
Nov 2, 2023
jcristau
force-pushed
the
google-auth
branch
from
01a874a to
1e0fa96
Compare
This is not backwards-compatible: we now require the service account credentials in json format instead of PKCS#12 (and as a result the username is no longer passed separately, since it is directly available in the json file) Fixes mozilla-releng#251
jcristau
force-pushed
the
google-auth
branch
from
1e0fa96 to
1fc8340
Compare
jcristau
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not backwards-compatible: we now require the service account credentials in json format instead of pkcs12.
Fixes #251