Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select role in signoff dialog to enable updates #3051

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file modified agent/run.sh
100755 → 100644
Empty file.
Empty file modified agent/scripts/test-entrypoint.sh
100755 → 100644
Empty file.
Empty file modified client/setup.py
100755 → 100644
Empty file.
Empty file modified maintenance/pin-helper.sh
100755 → 100644
Empty file.
Empty file modified maintenance/pin.sh
100755 → 100644
Empty file.
Empty file modified scripts/adhoc-tests.py
100755 → 100644
Empty file.
Empty file modified scripts/initdb_and_run.sh
100755 → 100644
Empty file.
Empty file modified scripts/manage-db.py
100755 → 100644
Empty file.
Empty file modified scripts/reset-stage-db.sh
100755 → 100644
Empty file.
Empty file modified scripts/run-batch-deletes.sh
100755 → 100644
Empty file.
Empty file modified scripts/run.sh
100755 → 100644
Empty file.
Empty file modified scripts/test-rules.py
100755 → 100644
Empty file.
Empty file modified src/auslib/blobs/apprelease.py
100755 → 100644
Empty file.
Empty file modified src/auslib/blobs/base.py
100755 → 100644
Empty file.
Empty file modified taskcluster/docker/skopeo/push_image.sh
100755 → 100644
Empty file.
Empty file modified taskcluster/scripts/get-coveralls-token
100755 → 100644
Empty file.
Empty file modified tests/blobs/test_apprelease.py
100755 → 100644
Empty file.
Empty file modified ui/scripts/deploy
100755 → 100644
Empty file.
4 changes: 4 additions & 0 deletions ui/src/views/Rules/ListRules/index.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -932,6 +932,9 @@ function ListRules(props) {
};

const handleSignoffEnableUpdates = async () => {
setRequiredRoles(
Object.keys(filteredRulesWithScheduledChanges[0].required_signoffs)
);
const [product, channel] = productChannelQueries;
const esDetails = emergencyShutoffs.find(
es => es.product === product && es.channel === channel
Expand Down Expand Up @@ -1068,6 +1071,7 @@ function ListRules(props) {
const dialogStates = {
delete: deleteDialogBody,
signoff: signoffDialogBody,
signoffEnableUpdates: signoffDialogBody,
disableUpdates: disableUpdatesBody,
};

Expand Down