Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

Bug 1812712 - Add "open in background tab" for bookmarks in the bookmarks manager #6049

Closed
wants to merge 4 commits into from

Conversation

Hoossayn
Copy link

@Hoossayn Hoossayn commented Mar 22, 2024

Demo video

https://www.loom.com/share/2a30877aee2340edab62e00522316403?sid=aa4e0fa4-68b9-487c-9eef-f9f493e97c05

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Breaking Changes: If this is a breaking Android Components change, please push a draft PR on Reference Browser to address the breaking issues.

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-apk-{fenix,focus,klar}-debug task you're interested in.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

https://bugzilla.mozilla.org/show_bug.cgi?id=1812712

Copy link
Contributor

🚧 Commit message is using the wrong format: chore: implement open in background in bookmark manager

The comment message should look like:

    Bug xxxx - Short description of your change
    Optionally, a longer description of the change.

@github-actions github-actions bot added the work in progress Not ready to land yet. Work in progress (WIP). label Mar 22, 2024
Copy link
Contributor

🚧 Commit message is using the wrong format: chore: implement open in background in bookmark manager

The comment message should look like:

    Bug xxxx - Short description of your change
    Optionally, a longer description of the change.

4 similar comments
Copy link
Contributor

🚧 Commit message is using the wrong format: chore: implement open in background in bookmark manager

The comment message should look like:

    Bug xxxx - Short description of your change
    Optionally, a longer description of the change.

Copy link
Contributor

🚧 Commit message is using the wrong format: chore: implement open in background in bookmark manager

The comment message should look like:

    Bug xxxx - Short description of your change
    Optionally, a longer description of the change.

Copy link
Contributor

🚧 Commit message is using the wrong format: chore: implement open in background in bookmark manager

The comment message should look like:

    Bug xxxx - Short description of your change
    Optionally, a longer description of the change.

Copy link
Contributor

🚧 Commit message is using the wrong format: chore: implement open in background in bookmark manager

The comment message should look like:

    Bug xxxx - Short description of your change
    Optionally, a longer description of the change.

Copy link
Contributor

🚧 Commit message is using the wrong format: chore: implement open in background in bookmark manager

The comment message should look like:

    Bug xxxx - Short description of your change
    Optionally, a longer description of the change.

Copy link
Contributor

🚧 Commit message is using the wrong format: chore: implement open in background in bookmark manager

The comment message should look like:

    Bug xxxx - Short description of your change
    Optionally, a longer description of the change.

@Hoossayn Hoossayn marked this pull request as ready for review March 22, 2024 13:38
@github-actions github-actions bot added 🕵️‍♀️ needs review PRs that need to be reviewed and removed work in progress Not ready to land yet. Work in progress (WIP). labels Mar 22, 2024
Copy link
Contributor

🚧 Commit message is using the wrong format: chore: implement open in background in bookmark manager

The comment message should look like:

    Bug xxxx - Short description of your change
    Optionally, a longer description of the change.

Copy link
Contributor

🚧 Commit message is using the wrong format: chore: implement open in background in bookmark manager

The comment message should look like:

    Bug xxxx - Short description of your change
    Optionally, a longer description of the change.

@Hoossayn Hoossayn changed the title Add "open in background tab" for bookmarks in the bookmarks manager Bug 1812712 - Add "open in background tab" for bookmarks in the bookmarks manager Mar 26, 2024
Copy link
Contributor

🚧 Commit message is using the wrong format: chore: implement open in background in bookmark manager

The comment message should look like:

    Bug xxxx - Short description of your change
    Optionally, a longer description of the change.

@gabrielluong
Copy link
Member

Hello @Hoossayn, Thank you so much for your contribution. We have moved our firefox-android repo over to mozilla-central. Please feel free to reopen a new PR against the new repo. You will have to clone the new repository and reapply your changes. Thank you again, and sorry for the inconvenience.

For more information, please see https://github.com/mozilla-mobile/firefox-android/wiki#upcoming-migration-to-mozilla-central.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕵️‍♀️ needs review PRs that need to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants