Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

CI for #5663 #6042

Closed
wants to merge 1 commit into from
Closed

Conversation

t-p-white
Copy link
Contributor

@t-p-white t-p-white commented Mar 20, 2024

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Breaking Changes: If this is a breaking Android Components change, please push a draft PR on Reference Browser to address the breaking issues.

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-apk-{fenix,focus,klar}-debug task you're interested in.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

https://bugzilla.mozilla.org/show_bug.cgi?id=1854131

…dscape mode

The popup doesn't fits up or fits down, because both availableHeightToTop and availableHeightToBottom are smaller than containerHeight. Because of this the popup is not displayed. As the popup is scrollable we should display it where the height is bigger (top or bottom).
Copy link
Contributor

🚧 Pull request title is using the wrong format: CI for #5663

The pull request title should look like:

  Bug xxxx - Short description of your change

@github-actions github-actions bot added the 🕵️‍♀️ needs review PRs that need to be reviewed label Mar 20, 2024
Copy link
Contributor

mergify bot commented Mar 20, 2024

⚠️ The sha of the head commit of this PR conflicts with #5663. Mergify cannot evaluate rules on this PR. ⚠️

@t-p-white t-p-white closed this Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕵️‍♀️ needs review PRs that need to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants