Added touch method to set last_used property
#96
Conversation
ghost
assigned 
lib/datastore.js
Outdated
| }; | ||
|
|
||
| await self.ldb.items.put(record); | ||
| self.recordMetric("touched", item.id); |
There was a problem hiding this comment.
this might require an update to the extension's metrics reporting ...
There was a problem hiding this comment.
this comment is really a note to go check the extension and ensure it won't cause additional failures.
There was a problem hiding this comment.
this might require an update to the extension's metrics reporting
this comment is really a note to go check the extension and ensure it won't cause additional failures
@linuxwolf Good call. @sashei is going to do a quick smoke test before merging and have a follow-up here to do corresponding follow-on work: mozilla-lockwise/lockbox-extension#661
lib/datastore.js
Outdated
| record = { | ||
| id, | ||
| encrypted, | ||
| last_used: record.last_used |
There was a problem hiding this comment.
this should be last_modified not last_used (and the same with record.last_used).
sashei
force-pushed
the
95-item-use-tracking
branch
from
075bb00 to
e74669e
Compare
sashei
force-pushed
the
95-item-use-tracking
branch
from
e74669e to
fe7e89d
Compare
.eslintrc.json
Outdated
| @@ -23,6 +23,7 @@ | |||
| "security/detect-non-literal-fs-filename": "off", | |||
| "security/detect-object-injection": "off", | |||
|
|
|||
| "no-console": "off", | |||
There was a problem hiding this comment.
I'm guessing this was put in place to troubleshoot tests, and just got missed with the last push. This option needs to be removed so we keep the default for "no-console" as "error".
lib/items.js
Outdated
| @@ -28,6 +28,7 @@ const SCHEMA = joi.object().keys({ | |||
| origins: joi.array().items(STRING_500).max(5).default([]), | |||
| tags: joi.array().items(STRING_500).max(10).default([]), | |||
| entry: joi.alternatives(ENTRY_SCHEMAS).required(), | |||
| last_used: joi.date().allow(null).default(null), | |||
There was a problem hiding this comment.
I'm not sure this is what we really want. Adding it to the schema allows the API user to define when last_used was, including removing it altogether (accidentally or otherwise).
Other read-only properties (e.g., modified, created, disabled) are handled as a separate step post Joi validation. That feels like the right behavior for this property, but I'm open to different opinions.
resolves #95