Merge pull request #168 from moviepediafilms/dev

hiding ranks from profile views
moviepediafilms · Dec 26, 2020 · 51c615a · 51c615a
2 parents 92d7635 + 72f22c8
commit 51c615a
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 11 deletions.
diff --git a/src/components/Leaderboard.vue b/src/components/Leaderboard.vue
@@ -53,7 +53,7 @@
             {{ my_profile.score }}
           </q-item-section>
           <q-item-section side style="min-width: 55px">
-            #{{ my_profile.rank }}
+            #{{ my_profile.creator_rank || my_profile.curator_rank }}
           </q-item-section>
         </q-item>
         <q-item
@@ -80,9 +80,7 @@
           <q-item-section side style="min-width: 55px">
             {{ user.score }}
           </q-item-section>
-          <q-item-section side style="min-width: 55px">
-            {{ user.rank == -1 ? "--" : `#${user.rank}` }}
-          </q-item-section>
+          <q-item-section side style="min-width: 55px"> -- </q-item-section>
         </q-item>
       </q-list>
     </transition>

diff --git a/src/components/ProfileAudience.vue b/src/components/ProfileAudience.vue
@@ -35,7 +35,7 @@
           <div class="col-4 text-center">
             <q-btn flat stack @click="on_rank_clicked">
               <div class="text-uppercase text-h5 text-weight-bolder">
-                {{ get_rank() }}
+                {{ rank_txt }}
               </div>
               <div class="q-mt-xs text-uppercase text-sm">rank</div>
             </q-btn>
@@ -202,6 +202,12 @@ export default {
       watchlist: (state) => state.watchlist,
       my_recommends: (state) => state.recommends,
     }),
+    rank_txt() {
+      return "-";
+      // TODO: add it back when screening starts
+      //eslint-disable-next-line
+      return this.profile.curator_rank == -1 ? "-" : this.profile.curator_rank;
+    },
     engagement() {
       // 6000 is the max score we are aiming at, as of now
       var score = this.my_profile.engagement_score / 6000;
@@ -280,10 +286,6 @@ export default {
       };
       return level_map[this.profile.level];
     },
-    get_rank() {
-      if (this.profile.rank != -1) return this.profile.rank;
-      else return "-";
-    },
     get_review_count() {
       //TODO: fetch top reviews that I have given to movies
       return "-";

diff --git a/src/components/ProfileFilmmaker.vue b/src/components/ProfileFilmmaker.vue
@@ -196,7 +196,10 @@ export default {
       return this.profile.id == this.my_profile.id;
     },
     rank_txt() {
-      return this.profile.rank == -1 ? "-" : this.profile.rank;
+      return "-";
+      // TODO: add it back when screening starts
+      //eslint-disable-next-line
+      return this.profile.creator_rank == -1 ? "-" : this.profile.creator_rank;
     },
     following_actions() {
       if (this.is_viewer_profile)

diff --git a/src/components/submit/ValueProps.vue b/src/components/submit/ValueProps.vue
@@ -15,7 +15,7 @@
       </template>
     </q-list>
     <div class="text-body1 q-my-sm text-grey-5">
-      <div class="text-title text-grey-4 text-weight-bold">
+      <div class="text-title text-grey-4">
         {{ rs }} 399 per Standard Submision
       </div>
       <div class="q-mt-sm text-body2">