Changes in Storm-POMDP for stormpy to work #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjunges
reviewed
Jun 28, 2023
src/storm-pomdp/api/verification.h
Outdated
| storm::pomdp::modelchecker::BeliefExplorationPomdpModelCheckerOptions<ValueType> options(false, true); | ||
| options.skipHeuristicSchedulers = true; | ||
| options.useClipping = false; | ||
| options.useStateEliminationCutoff = false; | ||
| options.sizeThresholdInit = sizeThreshold; | ||
| storm::pomdp::modelchecker::BeliefExplorationPomdpModelChecker<storm::models::sparse::Pomdp<ValueType>> modelchecker(pomdp, options); | ||
| storm::pomdp::modelchecker::BeliefExplorationPomdpModelChecker< |
There was a problem hiding this comment.
I dont understand why you need this change... it makes the code harder to read?
There was a problem hiding this comment.
Seems like a combination of a change that was not really necessary and some auto-formatting my editor did while committing apparently. I reverted the changes and everything still seemed to work, so let's try that.
|
LGTM. The failed CI tests stem from some unrelated issues with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains small changes to Storm-POMDP that are necessary to make the python bindings in stormpy work.