Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sponsorship Fee #896

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Sponsorship Fee #896

wants to merge 1 commit into from

Conversation

l-monninger
Copy link
Collaborator

Summary

  • RFCs: $\emptyset$
  • Categories: protocol-units

Adds a sponsorship fee on the L1 as an optional but recommended safety feature for movementlabsxyz/aptos-core#104

Testing

  1. Some tests updated for assertions. Generally, however, there is a lot that's unchecked in the current tests.

Outstanding issues

@l-monninger l-monninger changed the title Sponsored Feed Sponsorship Fee Nov 22, 2024
@l-monninger l-monninger mentioned this pull request Nov 22, 2024
Open
21 tasks
andygolay
andygolay approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@andygolay andygolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

If users have to pay for the sponsorship upfront, they'll appreciate it more.

And they'll only need to do it once, due to the check in is_sponsorship_eligible in movementlabsxyz/aptos-core#104

@andygolay andygolay linked an issue Nov 22, 2024 that may be closed by this pull request
Bridge Sponsored Gas (Initial) #835
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andygolay andygolay andygolay approved these changes

@andyjsbell andyjsbell Awaiting requested review from andyjsbell andyjsbell is a code owner

@0xmovses 0xmovses Awaiting requested review from 0xmovses 0xmovses is a code owner

@mzabaluev mzabaluev Awaiting requested review from mzabaluev mzabaluev is a code owner

@musitdev musitdev Awaiting requested review from musitdev musitdev is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bridge Sponsored Gas (Initial)
2 participants
@l-monninger @andygolay