Remove bridge struct

[Primata]

Summary

• RFCs: Link to RFC, Link to RFC, or $\emptyset$.
• Categories: any of protocol-units, networks, scripts, util, cicd, or misc.

Implementation of no struct bridge issued by #846 after getting exorbitantly expensive bridging.

Changelog

removes struct and adapts calls so it's fully dependent on hashing arguments.

Testing

cd to bridge contracts
forge test NativeBridgeMOVETest --gas-report

| src/NativeBridgeCounterpartyMOVE.sol:NativeBridgeCounterpartyMOVE contract |                 |       |        |       |         |
|----------------------------------------------------------------------------|-----------------|-------|--------|-------|---------|
| Deployment Cost                                                            | Deployment Size |       |        |       |         |
| 659978                                                                     | 2834            |       |        |       |         |
| Function Name                                                              | min             | avg   | median | max   | # calls |
| bridgeTransfers                                                            | 554             | 554   | 554    | 554   | 3       |
| completeBridgeTransfer                                                     | 944             | 10410 | 944    | 76518 | 8       |
| initialize                                                                 | 92870           | 92870 | 92870  | 92870 | 3       |
| lockBridgeTransfer                                                         | 5243            | 6003  | 5243   | 10568 | 14      |


| src/NativeBridgeInitiatorMOVE.sol:NativeBridgeInitiatorMOVE contract |                 |       |        |       |         |
|----------------------------------------------------------------------|-----------------|-------|--------|-------|---------|
| Deployment Cost                                                      | Deployment Size |       |        |       |         |
| 786068                                                               | 3417            |       |        |       |         |
| Function Name                                                        | min             | avg   | median | max   | # calls |
| initialize                                                           | 92904           | 92904 | 92904  | 92904 | 3       |
| initiateBridgeTransfer                                               | 69223           | 69223 | 69223  | 69223 | 1       |
| setCounterpartyAddress                                               | 24702           | 24702 | 24702  | 24702 | 3       |
| withdrawMOVE                                                         | 37552           | 37552 | 37552  | 37552 | 1       |

[franck44]

This implementation will make it very difficult to process refunds as we don't save the details of a transaction.
This is discussed in issue 846.

The savings are marginal and introduce more problems than they solve.

[Primata]

This implementation will make it very difficult to process refunds as we don't save the details of a transaction.

This is discussed in issue 846.

The savings are marginal and introduce more problems than they solve.

We do have the details of the transaction directly from eth_getLogs or if we choose to store on move storage only.
70% savings is far from marginal.

[0xmovses]

Closing as these contracts are removed for the Trusted Relayer, thanks for the optimisations here .