Implement Update Refunder during Deployment #854
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Primata
requested review from
l-monninger,
andyjsbell,
0xmovses,
mzabaluev and
musitdev
as code owners
l-monninger
reviewed
Nov 14, 2024
| "--compiled-script-path", | ||
| "protocol-units/bridge/move-modules/build/bridge-modules/bytecode_scripts/update_refunder.mv", | ||
| "--args", | ||
| "address:0xf90391c81027f03cdea491ed8b36ffaced26b6df208a9b569e5baf2590eb9b16", |
There was a problem hiding this comment.
Why is this guaranteed to work?
There was a problem hiding this comment.
Why can you hardcode an address here? Are we always using the same one in local development?
There was a problem hiding this comment.
Yes, it's hardcoded, just mimicked the current relayer one. I suspect that for mainnet we would set a new one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
protocol-units,networks,scripts,util,cicd, ormisc.This is a dependency of movementlabsxyz/aptos-core#98 which requires the deploy.rs to also change the refunder role to the same current address which is able to perform refunds. This future proofs changing the refunder and splitting concerns. This helps safe guard the relayer (bridge_operator) private key.
Changelog
Adds a call to update_refunder on atomic_bridge_configuration
Testing
Dependent on base tests.
Outstanding issues