Avoid races in CD container builds over symbolic references in checkouts #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't supply the symbolic GitHub reference name to the `ref` parameter of the checkout action in the build-push-container-all workflow jobs. The default behavior of actions/checkout would do the right thing checking out the SHA of the triggering event, thereby avoiding races with concurrent pushes to the repository modifying the symbolic references.
mzabaluev
requested review from
l-monninger,
andyjsbell and
0xmovses
as code owners
mzabaluev
added
cicd:suzuka-containers
cicd:bridge-containers
|
@mzabaluev I believe this will cause it to check out detached heads when responding to a label event. |
That may be actually the correct way to run: the symbolic branch head may have been pushed to another commit by the time the job runs, which has happened e.g. in https://github.com/movementlabsxyz/movement/actions/runs/11726835429/job/32668512421#step:2:215 I can restore the statements as well, but replace the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
cicd.Don't supply the symbolic GitHub reference name to the
refparameter of the checkout action in the build-push-container-all workflow jobs.The default behavior of actions/checkout would do the right thing, checking out the SHA of the triggering event, thereby avoiding races with concurrent pushes to the repository modifying the symbolic references.