Add Access Control, Refunder and Rate Limiter #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Primata
requested review from
l-monninger,
andyjsbell,
0xmovses and
mzabaluev
as code owners
0xmovses
requested changes
Nov 12, 2024
protocol-units/bridge/contracts/script/AtomicBridgeMOVEDeployer.s.sol
Outdated
Show resolved
Hide resolved
|
@0xmovses added abis |
|
Thanks, it seems that fixed client integration tests are imminently about to be merged to main, EOD / tomorrow morn. I would think its best for those fixed integration tests to go in then you get test these contract changes against main and we merge after that. Unless there is some other urgency I'm unaware of? |
|
This is the PR fyi, https://github.com/movementlabsxyz/movement/pull/690/commits Some rather large changes required with the way we test against the framework. Old testing work had to be rewritten. |
|
Putting this into draft as it refers to the old HTLC contracts, however we may want to refer to this code, so keeping it draft. |
Primata
changed the title
Primata
changed the base branch from
0xmovses/bridge-contract-deploy
to
main
andygolay
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
protocol-units,networks,scripts,util,cicd, ormisc.Adds AccessControlUpgradeable to BridgeInitiator and BridgeCounterparty
Changelog
DEFAULT_ADMIN_ROLE: _owner (is able to set roles and is able to set addresses and config)
RELAYER: _relayer (is able to call lockBridgeTransfer)
REFUNDER: _refunder (is able to call cancelBridgeTransfer and refundBridgeTransfer)
RateLiiter
Testing
Outstanding issues
Pending tests related to the overall deployment within the relayer framework testing.