Testnet Transaction Health #726
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l-monninger
requested review from
andyjsbell,
0xmovses and
mzabaluev
as code owners
mzabaluev
reviewed
Oct 22, 2024
Comment on lines
+28
to
+39
| suzuka-client-e2e-simple-interaction-healthcheck-watcher: | ||
| image: busybox | ||
| container_name: ledger-should-progress-watcher | ||
| command: > | ||
| sh -c ' | ||
| while true; do | ||
| sleep 1000 | ||
| done | ||
| ' | ||
| depends_on: | ||
| suzuka-client-e2e-simple-interaction-healthcheck: | ||
| condition: service_healthy |
There was a problem hiding this comment.
I don't understand the purpose of this "service". Is it a stub to add the ledger-should-progress script from #717 later? The name is different, so it would not work as an overlay.
There was a problem hiding this comment.
In docker-compose, you can force the entire application to crash by creating a dependent service.
There was a problem hiding this comment.
This is "Induced Crash" above.
|
@radupopa369 this is the PR I had mentioned to you... I wasn't sure whether your monitoring already implements similar health checks, sending in transactions that simulate user interactions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
networksA simple implementation of a health check that uses the existing containers, towards MIP-26.
Note: the binary being used will only be valid for testnet as it requires a faucet. This can modified, however, s.t. this health-check approach can be generalized.
Induced-crash
Like #717 , this check will crash the docker-compose application on the whole if the test criteria aren't meant, thereby generating an outage that will be reported for monitoring.
Composition-based with Write to Common File
A slightly more sophisticated approach might be to write the exit code of the looped check into the
DOT_MOVEMENT_PATHat a well known file and serve this status in the watcher.e2e Tests as Health Check Services
A more sophisticated approach still would adjust the running modes of the
suzuka-client-e2e-simple-interactionto include ahealthcheckmode which would be run to serve this through the docker compose application. When we transition tok8sandhelmthroughout our infra this will be needed. An example of this approach is drafted in #727 .