[draft] update MCR to include a confirmer role #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l-monninger
reviewed
Oct 18, 2024
|
|
||
| address[] memory attesters = getAttesters(); | ||
| // map the blockhash to the attesters | ||
| uint256 leaderIndex = uint256(blockHash) % attesters.length; |
There was a problem hiding this comment.
I'm sure this is in the MDs that I haven't gotten to you, but doesn't this particular election allow a leader to just mine for a blockhash that would elect themselves. Really, we would want quorum-based leader election if we are going to introduce a leader.
There was a problem hiding this comment.
It's L1 blockhash not L2. My assumption is L1 blockhash is not predictable or cannot be influenced by the L2 validators
There was a problem hiding this comment.
(Long term I think this is also not a great assumption but it buys time to look into a better randomness solution )
apenzk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
protocol-unitsIntroduces the role of Confimer in the MCR contract. The confirmer is selected based on L1 randomness and serves for a certain term period.
Motiviation
Currently rewarding based on time of commitment and the complexity that arises from the last committer having higher commit cost and different rewards may cause race conditions, co-location and centralization.
This can be resolved by separating the tasks into attesters and confirmer, where confirmer is a new role that converts provided attester commitments into a proof and update the state. Note that the confirmer has not to be from the epoch that the L2-block or the attestations are. The sole role of the comitter is to advance the acceptance.
As a simple first PoC the current confirmer could be selected based on "slow" randomness from L1. E.g. using hashes from L1-blocks.
Changelog
Testing
Outstanding issues