Aptos: instantiate the provider, some code cleanups #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trivially return None.
Don't wrap the aptos SDK's client with a newtype and Deref, this is an antipattern and serves no useful purpose. Use the Url type in the APIs rather than converting to and from strings. Have a private constructor for AptosHpProvider to indicate silly clones enforced by hyperlane-core API.
|
We need to shed those CI checks that we don't care about, but they fail. Broken window syndrome and all that. |
0xmovses
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
hyperlane-aptosprovider inChainConf::build_provider.HyperlaneProvider::get_chain_metricsforAptosHpProviderby returningOk(None).Derefs to the real thing.Urlin APIs rather than converting to and from strings.Drive-by changes
Formatting and use items reordering in the touched files.
Backward compatibility
Yes (unless hyperlane-aptos has been released under semver somewhere).
Testing
None (yet)