Dueka/update header #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for rococo-selkie-abda2e ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for blue-explorer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
vpallegar
reviewed
Nov 14, 2024
There was a problem hiding this comment.
Few things here.
- Need the network selector on mobile to be visible nex to the menu icon..dont want the user to have to click open on the nav to see the network selector.
- You removed the analytics button in the header for desktop and mobile nav but that is still needed for the networks that have them. So it should be added back like before.
There was a problem hiding this comment.
I would confirm if the pnpm-lock.yaml is needed, but it would likely be removed from the next commit, the analytics button would be added in the next commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.