Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typos #120

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@

The Move programming language poses numerous benefits to builders including direct interaction with digital assets through custom resource types, flexibility with transaction script declaration, on-chain verification, and bytecode safety privileges.

Movement M1 is designed for the Avalanche subnet, allowing users to seamlessly interact with and build with the Move language on on a high-performance, modular, scalable and interoperable Layer 1.
Movement M1 is designed for the Avalanche subnet, allowing users to seamlessly interact with and build with the Move language on a high-performance, modular, scalable and interoperable Layer 1.

- Movement will be able to hit 160,000+ theoretical TPS as the project scales to provide much needed performance to protocols.
- Move bytecode verifiers and interpreters provide native solvency for the reentrancy attacks and security woes that have plagued Solidity developers for years, resulting in $3 billion lost last year.
Expand Down
2 changes: 1 addition & 1 deletion m1/DEBUGGING.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ In order for the indexer to write to the database listening on port `5432`, you
```shell
docker run --name m1-indexer-db -e POSTGRES_PASSWORD=postgres -p 5432:5432 -d postgres
```
If you are not running the database, the trailer thread in the M1 subnet will panick. However, this will not affect the rest of the execution.
If you are not running the database, the trailer thread in the M1 subnet will panic. However, this will not affect the rest of the execution.

# WIP
We are pursuing several improvements to local debugging and testing.
Expand Down
6 changes: 3 additions & 3 deletions m1/infrastructure/evm-rpc/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ The following RPC methods have been implemented to ensure interaction with Solid

### Start Your EVM RPC

> If you don't want to start the EVM RPC yourself, you can found the link at `https://github.com/movemntdev/movement-v2`
> If you don't want to start the EVM RPC yourself, you can find the link at `https://github.com/movemntdev/movement-v2`

- Set environment variables
```bash
Expand All @@ -42,9 +42,9 @@ mv .env.example .env

- `NODE_URL`: The subnet restful endpoint provided by the movement subnet`

- `EVM_SENDER`: The private key of a account to send EVM transactions to the Move. Please ensure that the account has enough MOVE native token to pay for the gas fee.(At least 10)
- `EVM_SENDER`: The private key of an account to send EVM transactions to the Move. Please ensure that the account has enough MOVE native token to pay for the gas fee. (At least 10)

- `FAUCET_SENDER`: The private key of a account to send bridge move native token to evm native token. Please ensure that the account has enough MOVE native token to pay for the gas fee and bridge token.(At least 10)
- `FAUCET_SENDER`: The private key of an account to send bridge move native token to evm native token. Please ensure that the account has enough MOVE native token to pay for the gas fee and bridge token. (At least 10)


Then, run the following command to start the server:
Expand Down
8 changes: 4 additions & 4 deletions movement-sdk/CANONICAL.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ This doc serves as a general developer onboarding and point of reference for Can
## Overview
The Canonical VM is a virtual machine and storage layer solution to the Move VM interoperability. It commits to the idea that modifying the various storage resolvers and natives associated with the different Move VMs can allow them to operate over the same derived state without having to completely reproduce the VMs individually.

Currently, the greatest challenge facing the Canonical VM project is the difficulty presented by Sui's object runtime which is closely entangled with its unique for of consensus. This is discussed at length elsewhere, and while working on this project you will become closely acquainted with these challenges. The bottom line is: Sui doesn't have traditional blocks and there's a lot you have to do to make Sui-like execution work outside of the Sui network.
Currently, the greatest challenge facing the Canonical VM project is the difficulty presented by Sui's object runtime which is closely entangled with its unique form of consensus. This is discussed at length elsewhere, and while working on this project you will become closely acquainted with these challenges. The bottom line is: Sui doesn't have traditional blocks and there's a lot you have to do to make Sui-like execution work outside of the Sui network.

## Getting Started
Here are resources that will help you to get started with the project. Some of them are traditional reading material, other videos, others are particularly important docs and code snippets.
Expand Down Expand Up @@ -47,8 +47,8 @@ While we are not implementing Narwhal Consensus for any of the layers involved i
[`execute_transaction_to_effects`](https://github.com/MystenLabs/sui/blob/552158d9eae200314499809d8977f732f6c2cee7/sui-execution/src/latest.rs#L79) is the highest level of execution where don't actually have to get entangled with Sui's consensus and transactions lifecycle. However, we want to draw heavily from the approaches put forth in the path between [`try_execute_immediately`](https://github.com/MystenLabs/sui/blob/dd4514d5d7ebffadcd25ac6e0cbf9a63e375dcf7/crates/sui-core/src/authority.rs#L1339) and [`prepare_certificate`](https://github.com/MystenLabs/sui/blob/dd4514d5d7ebffadcd25ac6e0cbf9a63e375dcf7/crates/sui-core/src/authority.rs#L950).

**💡 Key Concepts**
- There is a path that ostensibly allows us to do and/or mimic the object runtime without having to get entangled with consensus and the transaction lifecycle too deeply. It requires, however, implementing a lot dependencies that currently are provided from that domain.
- If the above turns out not to be the case, we essentially have to start looking going a bit lower to replace `execute_transaction_to_effects` and building many of the same dependencies that are currently scoped.
- There is a path that ostensibly allows us to do and/or mimic the object runtime without having to get entangled with consensus and the transaction lifecycle too deeply. It requires, however, implementing a lot of dependencies that currently are provided from that domain.
- If the above turns out not to be the case, we essentially have to start looking at going a bit lower to replace `execute_transaction_to_effects` and building many of the same dependencies that are currently scoped.
- Maybe we're wrong? Do you see something new?

### Our Source
Expand All @@ -62,4 +62,4 @@ Both of the above document progressive learning through the project. Please abso
- We were dissuaded from the above approach by Mysten Labs when we thought that the `CheckpointExecutor` might be a better analog.
- We were dissuaded from the `CheckpointExecutor` approach when we realized that it would be more difficult to make the necessary modifications.
- We are now back to attempting to use `execute_transaction_to_effects` and are trying to build the dependencies that we need to do so.
- **!!![The Dependencies of `execute_transaction_to_effects`](https://github.com/movemntdev/M1/tree/dev/movement-sdk/execution/sui-block-executor#the-dependencies-of-execute_transaction_to_effects) is perhaps the most useful section once you have a sense o things. It maps out the dependencies we need to implement. !!!**
- **!!![The Dependencies of `execute_transaction_to_effects`](https://github.com/movemntdev/M1/tree/dev/movement-sdk/execution/sui-block-executor#the-dependencies-of-execute_transaction_to_effects) is perhaps the most useful section once you have a sense of things. It maps out the dependencies we need to implement. !!!**
4 changes: 2 additions & 2 deletions movement-sdk/clis/aptos/README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Aptos Command Line Interface (CLI) Tool

The `movement` tool is a command line interface (CLI) for debugging, development, and node operation.
See [Movement CLI Documentation](https://aptos.dev/cli-tools/aptos-cli-tool/install-aptos-cli) for how to install the `movment` CLI tool and how to use it.
<!-- TODO: update the above when the docs are complete. -->
See [Movement CLI Documentation](https://aptos.dev/cli-tools/aptos-cli-tool/install-aptos-cli) for how to install the `movement` CLI tool and how to use it.
<!-- TODO: update the above when the docs are complete. -->