Refactored CMakeLists.txt for easier integration of next benchmarks #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjahr
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Makes sense 👍 You can add moveit_package(). It's a cmake macro that does of the standardized configurations for all moveit packages: https://github.com/moveit/moveit2/blob/b88af3296cda51953f8b05627c39a4d9a2fe7e37/moveit_common/cmake/moveit_package.cmake
|
Thank you for review, CI gives fail due to migration issues ( #42 ). Could you approve this PR again? |
sjahr
approved these changes
Oct 10, 2024
CihatAltiparmak
deleted the
fix/refactor_cmake_files_for_easier_integration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, i'm aiming to ease the integration of other implemented benchmarks. Additionaly, i'm wondering whether
moveit_package()part should be used in CMakeLists.txt For example:https://github.com/moveit/moveit2/blob/b88af3296cda51953f8b05627c39a4d9a2fe7e37/moveit_ros/planning_interface/CMakeLists.txt#L5-L6
By the way if we merge this PR into main branch, i will update other draft PRs based on this PR.