-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEMP: Remove ros-*-geometric-shapes to force using source package #3137
base: main
Are you sure you want to change the base?
Conversation
Note that moveit/geometric_shapes#253 only takes effect after a new release or if the binary package (and its headers in /opt/ros//include/geometric_shapes/) are removed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3137 +/- ##
==========================================
- Coverage 46.01% 46.00% -0.00%
==========================================
Files 483 483
Lines 40632 40632
==========================================
- Hits 18691 18687 -4
- Misses 21941 21945 +4 ☔ View full report in Codecov by Sentry. |
I see. So should we pin to the "hack" commit for now, and cut a release of I'm doubtful of the effectiveness of a temporary |
We just need to remove the installed binary package. |
Seems that alone didn't quite work, unless there's some caching that is persisting |
Nah, it just does not have binary installs to remove, it seems
https://github.com/moveit/moveit2/actions/runs/12072620084/job/33666989895?pr=3137#step:11:261 |
896578f
to
e7f581f
Compare
For some reason, the glob didn't work. Using the exact name should work now. |
e7f581f
to
9d13bd2
Compare
And of course we need |
This works. Reverting change to moveit2.repos... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be merged. After releasing and syncing geometric_shapes, the commit should be reverted.
geometric_shapes
in CI
Description
Testing the effects of moveit/geometric_shapes#253 in CI.
Turns out that until a release of
geometric_shapes
is cut, we can temporarily uninstall the binaries in CI.Checklist