Add Blacklisting API #142
Merged
Add Blacklisting API #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nilspenzel
commented
Sep 5, 2024
nilspenzel
commented
added 2 commits
September 5, 2024 11:08
Enables fast checking of some necessary conditions for new the viability of new Tours.
felixguendling
force-pushed
the
master
branch
from
639216a
to
90785a6
Compare
Comment on lines
19
to
30
| return json( | ||
| { | ||
| body: JSON.stringify( | ||
| getViableBusStops( | ||
| parameters.userChosen, | ||
| parameters.busStops, | ||
| parameters.startFixed, | ||
| parameters.capacities | ||
| ) | ||
| ) | ||
| }, | ||
| { status: 200 } |
There was a problem hiding this comment.
Suggested change
| return json( | |
| { | |
| body: JSON.stringify( | |
| getViableBusStops( | |
| parameters.userChosen, | |
| parameters.busStops, | |
| parameters.startFixed, | |
| parameters.capacities | |
| ) | |
| ) | |
| }, | |
| { status: 200 } | |
| return json( | |
| getViableBusStops( | |
| parameters.userChosen, | |
| parameters.busStops, | |
| parameters.startFixed, | |
| parameters.capacities | |
| ) |
| startFixed ? t : new Date(t.getTime() - MAX_PASSENGER_WAITING_TIME_DROPOFF), | ||
| startFixed ? new Date(t.getTime() + MAX_PASSENGER_WAITING_TIME_PICKUP) : t | ||
| ); | ||
| new Date(times[j]); |
felixguendling
approved these changes
Sep 19, 2024
steffenheger
approved these changes
Sep 19, 2024
| import type { Capacities } from './capacities'; | ||
| import type { Coordinates } from './location'; | ||
|
|
||
| export type BookingRequestParameters = { |
There was a problem hiding this comment.
BlacklistingRequestParameters ?
There was a problem hiding this comment.
Ich gehe aktuell davon aus, dass das Whiteling Parameter nach dem selben Schema Parameter annehmen wird.
Daher würde ich erstmal bei der allgemeineren Version bleiben.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.