Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global timeout for all operations within connection #259

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

decaz
Copy link
Collaborator

@decaz decaz commented Oct 3, 2019

Currently every operation should be called with timeout parameter to catch timeout of operations. With operation_timeout parameter of connection it would be much easier.

@decaz decaz changed the title Add global timeout for all operations within connection [WIP] Add global timeout for all operations within connection Oct 3, 2019
@decaz
Copy link
Collaborator Author

decaz commented Oct 3, 2019

Default value of timeout parameters should be some special object (OPERATION_TIMEOUT for example) because None should mean no timeout at all. Will add it soon. Done.

tests/test_amqp.py Outdated Show resolved Hide resolved
@decaz decaz changed the title [WIP] Add global timeout for all operations within connection Add global timeout for all operations within connection Oct 4, 2019
@decaz decaz force-pushed the operation-timeout branch from 74799ce to ec9c803 Compare October 4, 2019 11:19
@mosquito
Copy link
Owner

Please rebase

@decaz decaz force-pushed the operation-timeout branch from ec9c803 to 7aa9991 Compare November 20, 2019 09:53
@decaz
Copy link
Collaborator Author

decaz commented Nov 20, 2019

@mosquito done.

@mosquito
Copy link
Owner

Sorry for long answer, but why you want to add a parameter to the methods and use asyncio.wait_for inside them instead of wrapping asyncio.wait_for externally?

@decaz
Copy link
Collaborator Author

decaz commented Feb 14, 2020

@mosquito because wait_for and timeout parameters are already inside library methods and you don't have to wrap them everywhere within your code.

@decaz decaz force-pushed the operation-timeout branch from 7aa9991 to 19868d1 Compare February 14, 2020 17:18
@aviramha
Copy link
Contributor

aviramha commented Dec 9, 2020

Update on this?

@mosquito
Copy link
Owner

please resolve conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants