Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor amount -> assets #266

Closed
wants to merge 6 commits into from
Closed

Conversation

MerlinEgalite
Copy link
Contributor

@MerlinEgalite MerlinEgalite commented Aug 11, 2023

Fixes #264

@MerlinEgalite MerlinEgalite requested review from a team, Rubilmax, pakim249CAL, Jean-Grimal, makcandrov, QGarchery, peyha and MathisGD and removed request for a team August 11, 2023 07:02
@MerlinEgalite MerlinEgalite linked an issue Aug 11, 2023 that may be closed by this pull request
Base automatically changed from docs/natspecs to main August 11, 2023 10:09
@MerlinEgalite MerlinEgalite marked this pull request as ready for review August 11, 2023 11:54
src/Blue.sol Outdated Show resolved Hide resolved
Co-authored-by: Romain Milon <[email protected]>
Signed-off-by: Merlin Egalite <[email protected]>
Rubilmax
Rubilmax previously approved these changes Aug 11, 2023
@makcandrov
Copy link
Contributor

makcandrov commented Aug 11, 2023

Not related to this PR but it can be fixed here. There is a typo here:

https://github.com/morpho-labs/morpho-blue/blob/e042277b62cbac220d3dff1fbd89c296554b434e/src/interfaces/IBlue.sol#L125

Otherwise, I have already given my opinion here #264 (comment)

pakim249CAL
pakim249CAL previously approved these changes Aug 11, 2023
@MerlinEgalite MerlinEgalite marked this pull request as draft August 11, 2023 15:14
@MerlinEgalite
Copy link
Contributor Author

Hardcore merge...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change "amount" for "assets"
5 participants