-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor amount -> assets #266
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MerlinEgalite
requested review from
a team,
Rubilmax,
pakim249CAL,
Jean-Grimal,
makcandrov,
QGarchery,
peyha and
MathisGD
and removed request for
a team
August 11, 2023 07:02
Rubilmax
reviewed
Aug 11, 2023
Co-authored-by: Romain Milon <[email protected]> Signed-off-by: Merlin Egalite <[email protected]>
Rubilmax
previously approved these changes
Aug 11, 2023
Not related to this PR but it can be fixed here. There is a typo here: Otherwise, I have already given my opinion here #264 (comment) |
pakim249CAL
previously approved these changes
Aug 11, 2023
MathisGD
reviewed
Aug 11, 2023
MerlinEgalite
dismissed stale reviews from pakim249CAL and Rubilmax
via
August 11, 2023 14:17
60f917f
pakim249CAL
approved these changes
Aug 11, 2023
Hardcore merge... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #264