Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Natspecs #238

Merged
merged 15 commits into from
Aug 11, 2023
Merged

Add Natspecs #238

merged 15 commits into from
Aug 11, 2023

Conversation

MerlinEgalite
Copy link
Contributor

@MerlinEgalite MerlinEgalite commented Aug 8, 2023 •
edited
Loading

Fixes #39, #244 and #232

@MerlinEgalite MerlinEgalite requested review from a team, Rubilmax, pakim249CAL, Jean-Grimal, makcandrov, QGarchery and MathisGD and removed request for a team August 8, 2023 12:45
MathisGD
MathisGD reviewed Aug 8, 2023
View reviewed changes
src/libraries/SharesMath.sol Outdated Show resolved Hide resolved
src/libraries/SharesMath.sol Outdated Show resolved Hide resolved
MerlinEgalite
MerlinEgalite commented Aug 8, 2023
View reviewed changes
Copy link
Contributor Author

@MerlinEgalite MerlinEgalite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not touch the SafeTransferLib and the FixedPointMathLib as it's not settled what we'll do with those 2 files.

I've left some comments and questions I have.

src/Blue.sol Outdated Show resolved Hide resolved
src/Blue.sol Outdated Show resolved Hide resolved
src/interfaces/IFlashLender.sol Outdated Show resolved Hide resolved
src/Blue.sol Outdated Show resolved Hide resolved
@MerlinEgalite MerlinEgalite marked this pull request as ready for review August 8, 2023 15:38
MathisGD
MathisGD reviewed Aug 8, 2023
View reviewed changes
src/Blue.sol Outdated Show resolved Hide resolved
MathisGD
MathisGD reviewed Aug 8, 2023
View reviewed changes
src/libraries/Errors.sol Outdated Show resolved Hide resolved
Rubilmax
Rubilmax reviewed Aug 8, 2023
View reviewed changes
src/Blue.sol Outdated Show resolved Hide resolved
src/interfaces/IBlue.sol Outdated Show resolved Hide resolved
src/interfaces/IBlue.sol Outdated Show resolved Hide resolved
src/interfaces/IBlue.sol Outdated Show resolved Hide resolved
src/interfaces/IBlue.sol Outdated Show resolved Hide resolved
@pakim249CAL pakim249CAL mentioned this pull request Aug 8, 2023
Closed
Rubilmax
Rubilmax reviewed Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@Rubilmax Rubilmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review

@Rubilmax Rubilmax mentioned this pull request Aug 9, 2023
Closed
MathisGD
MathisGD reviewed Aug 10, 2023
View reviewed changes
src/libraries/SharesMath.sol Outdated Show resolved Hide resolved
src/libraries/SharesMath.sol Outdated Show resolved Hide resolved
src/libraries/SharesMath.sol Outdated Show resolved Hide resolved
src/libraries/SharesMath.sol Outdated Show resolved Hide resolved
src/Blue.sol Outdated Show resolved Hide resolved
@MathisGD MathisGD linked an issue Aug 10, 2023 that may be closed by this pull request
Fee cannot be redeemed by the recipient on illiquid markets #244
Closed
Rubilmax
Rubilmax reviewed Aug 10, 2023
View reviewed changes
src/interfaces/IIrm.sol Outdated Show resolved Hide resolved
Jean-Grimal
Jean-Grimal previously approved these changes Aug 10, 2023
View reviewed changes
@MerlinEgalite MerlinEgalite mentioned this pull request Aug 10, 2023
Closed
@MerlinEgalite MerlinEgalite linked an issue Aug 10, 2023 that may be closed by this pull request
Should we add the supplyRate to the AccrueInterests event? #232
Closed
MathisGD
MathisGD reviewed Aug 11, 2023
View reviewed changes
Copy link
Contributor

@MathisGD MathisGD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then approving

src/Blue.sol Outdated Show resolved Hide resolved
src/Blue.sol Outdated Show resolved Hide resolved
src/Blue.sol Outdated Show resolved Hide resolved
src/interfaces/IBlue.sol Show resolved Hide resolved
src/interfaces/IBlue.sol Outdated Show resolved Hide resolved
src/interfaces/IBlue.sol Outdated Show resolved Hide resolved
src/interfaces/IBlue.sol Show resolved Hide resolved
src/interfaces/IBlue.sol Show resolved Hide resolved
src/interfaces/IBlueCallbacks.sol Outdated Show resolved Hide resolved
src/interfaces/IERC20.sol Outdated Show resolved Hide resolved
Rubilmax
Rubilmax approved these changes Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@Rubilmax Rubilmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving optimistically. Details will be fixed in a later PR

@MerlinEgalite MerlinEgalite merged commit e042277 into main Aug 11, 2023
4 checks passed
@MerlinEgalite MerlinEgalite deleted the docs/natspecs branch August 11, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makcandrov makcandrov makcandrov approved these changes

@Jean-Grimal Jean-Grimal Jean-Grimal approved these changes

@MathisGD MathisGD MathisGD approved these changes

@pakim249CAL pakim249CAL pakim249CAL approved these changes

@Rubilmax Rubilmax Rubilmax approved these changes

@QGarchery QGarchery Awaiting requested review from QGarchery QGarchery was automatically assigned from morpho-labs/protocol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@MerlinEgalite @Rubilmax @pakim249CAL @MathisGD @Jean-Grimal @makcandrov