-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: invariant tests #231
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakim249CAL
reviewed
Aug 7, 2023
Signed-off-by: Jean-Grimal <[email protected]>
…feat/invariant-tests
pakim249CAL
reviewed
Aug 9, 2023
9 tasks
makcandrov
reviewed
Aug 9, 2023
…feat/invariant-tests
…feat/invariant-tests
…feat/invariant-tests
…feat/invariant-tests
pakim249CAL
approved these changes
Aug 21, 2023
Rubilmax
reviewed
Aug 21, 2023
I agree the single market, single user test case is not that interesting |
MerlinEgalite
previously approved these changes
Aug 21, 2023
MathisGD
previously approved these changes
Aug 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job !
test/forge/invariant/TestInvariantSingleMarketChangingPrice.t.sol
Outdated
Show resolved
Hide resolved
test/forge/invariant/TestInvariantSingleMarketChangingPrice.t.sol
Outdated
Show resolved
Hide resolved
test/forge/invariant/TestInvariantSingleMarketChangingPrice.t.sol
Outdated
Show resolved
Hide resolved
test/forge/invariant/TestInvariantSingleMarketChangingPrice.t.sol
Outdated
Show resolved
Hide resolved
pakim249CAL
previously approved these changes
Aug 21, 2023
Jean-Grimal
dismissed stale reviews from pakim249CAL, MathisGD, and MerlinEgalite
via
August 22, 2023 08:27
b45366c
Closed
2 tasks
MathisGD
previously approved these changes
Aug 22, 2023
Rubilmax
previously approved these changes
Aug 22, 2023
MerlinEgalite
requested review from
pakim249CAL,
MathisGD,
Rubilmax and
MerlinEgalite
August 22, 2023 16:06
MerlinEgalite
approved these changes
Aug 22, 2023
MathisGD
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented 4 contexts :
I wanted to cover lots of scenarios, but maybe one of this context is useless (the one with a single user for exemple), and should be removed