Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: invariant tests #231

Merged
merged 50 commits into from
Aug 22, 2023
Merged

Feat: invariant tests #231

merged 50 commits into from
Aug 22, 2023

Conversation

Jean-Grimal
Copy link
Contributor

@Jean-Grimal Jean-Grimal commented Aug 7, 2023

I implemented 4 contexts :

  • 3 with fix prices (and therefore no liquidations) : one with one market and only one user, one with one market and 8 users, and one with 2 markets and 8 users.
  • Another one with variable prices (variations are bounded between 2 and 20%), with one market and 8 users

I wanted to cover lots of scenarios, but maybe one of this context is useless (the one with a single user for exemple), and should be removed

test/forge/BlueInvariantBase.t.sol Outdated Show resolved Hide resolved
test/forge/BlueInvariantBase.t.sol Outdated Show resolved Hide resolved
test/forge/invariant/TestInvariantSingleMarket.t.sol Outdated Show resolved Hide resolved
test/forge/invariant/TestInvariantSingleMarket.t.sol Outdated Show resolved Hide resolved
@Rubilmax
Copy link
Collaborator

I wanted to cover lots of scenarios, but maybe one of this context is useless (the one with a single user for exemple), and should be removed

I agree the single market, single user test case is not that interesting

MerlinEgalite
MerlinEgalite previously approved these changes Aug 21, 2023
MathisGD
MathisGD previously approved these changes Aug 21, 2023
Copy link
Contributor

@MathisGD MathisGD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job !

pakim249CAL
pakim249CAL previously approved these changes Aug 21, 2023
@MathisGD MathisGD mentioned this pull request Aug 22, 2023
2 tasks
@MathisGD MathisGD linked an issue Aug 22, 2023 that may be closed by this pull request
2 tasks
MathisGD
MathisGD previously approved these changes Aug 22, 2023
Rubilmax
Rubilmax previously approved these changes Aug 22, 2023
@Jean-Grimal Jean-Grimal dismissed stale reviews from Rubilmax and MathisGD via 6dd4d7d August 22, 2023 15:40
@MathisGD MathisGD merged commit 590678d into main Aug 22, 2023
4 checks passed
@MathisGD MathisGD deleted the feat/invariant-tests branch August 22, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing tests
6 participants