Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fee tests #33

Merged
merged 24 commits into from
Sep 21, 2023
Merged

Add fee tests #33

merged 24 commits into from
Sep 21, 2023

Conversation

MerlinEgalite
Copy link
Contributor

@MerlinEgalite MerlinEgalite commented Sep 10, 2023 •
edited by Rubilmax
Loading

Adds fee tests

@MerlinEgalite MerlinEgalite linked an issue Sep 11, 2023 that may be closed by this pull request
Instant revenue for the fee recipient #35
Closed
Base automatically changed from test/deposit-withdraw-tests to main September 12, 2023 16:48
@Rubilmax Rubilmax changed the base branch from main to fix/zero-fee-recipient September 20, 2023 08:17
@Rubilmax Rubilmax changed the title test: draft Add fee tests Sep 20, 2023
@Rubilmax Rubilmax marked this pull request as ready for review September 20, 2023 09:00
MerlinEgalite
MerlinEgalite commented Sep 20, 2023
View reviewed changes
Copy link
Contributor Author

@MerlinEgalite MerlinEgalite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/forge/helpers/BaseTest.sol Outdated Show resolved Hide resolved
Jean-Grimal
Jean-Grimal reviewed Sep 20, 2023
View reviewed changes
test/forge/FeeTest.sol Outdated Show resolved Hide resolved
Jean-Grimal
Jean-Grimal reviewed Sep 20, 2023
View reviewed changes
test/forge/FeeTest.sol Outdated Show resolved Hide resolved
Base automatically changed from fix/zero-fee-recipient to main September 20, 2023 13:58
MerlinEgalite
MerlinEgalite commented Sep 21, 2023
View reviewed changes
Copy link
Contributor Author

@MerlinEgalite MerlinEgalite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rubilmax Rubilmax merged commit 45b1b9e into main Sep 21, 2023
5 of 6 checks passed
@Rubilmax Rubilmax deleted the test/fees branch September 21, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jean-Grimal Jean-Grimal Jean-Grimal approved these changes

@Rubilmax Rubilmax Rubilmax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Instant revenue for the fee recipient
3 participants
@MerlinEgalite @Rubilmax @Jean-Grimal