Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor allocation #112

Merged
merged 18 commits into from
Sep 27, 2023
Merged

Refactor allocation #112

merged 18 commits into from
Sep 27, 2023

Conversation

MerlinEgalite
Copy link
Contributor

Fixes #109 and #102

@MerlinEgalite MerlinEgalite requested a review from a team September 25, 2023 14:27
@MerlinEgalite MerlinEgalite self-assigned this Sep 25, 2023
@MerlinEgalite MerlinEgalite requested review from Rubilmax and Jean-Grimal and removed request for a team September 25, 2023 14:27
@MerlinEgalite MerlinEgalite linked an issue Sep 25, 2023 that may be closed by this pull request
MarketAllocation could have a shares field #102
Closed
@MerlinEgalite MerlinEgalite marked this pull request as draft September 25, 2023 14:28
@MerlinEgalite
Copy link
Contributor Author

I can't test with hardhat because of this error, @Rubilmax do you have any clue?

Screenshot 2023-09-25 at 16 54 16

@MerlinEgalite MerlinEgalite marked this pull request as ready for review September 25, 2023 14:54
Rubilmax
Rubilmax suggested changes Sep 25, 2023
View reviewed changes
src/MetaMorpho.sol Outdated Show resolved Hide resolved
src/MetaMorpho.sol Show resolved Hide resolved
src/interfaces/IMetaMorpho.sol Outdated Show resolved Hide resolved
Jean-Grimal
Jean-Grimal reviewed Sep 25, 2023
View reviewed changes
src/MetaMorpho.sol Outdated Show resolved Hide resolved
@MerlinEgalite
Copy link
Contributor Author

I need to update tests

Rubilmax
Rubilmax reviewed Sep 26, 2023
View reviewed changes
src/MetaMorpho.sol Outdated Show resolved Hide resolved
MerlinEgalite
MerlinEgalite commented Sep 27, 2023
View reviewed changes
Copy link
Contributor Author

@MerlinEgalite MerlinEgalite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rubilmax Rubilmax self-requested a review September 27, 2023 14:58
MerlinEgalite
MerlinEgalite commented Sep 27, 2023
View reviewed changes
Copy link
Contributor Author

@MerlinEgalite MerlinEgalite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MerlinEgalite MerlinEgalite merged commit e556a13 into main Sep 27, 2023
6 checks passed
@MerlinEgalite MerlinEgalite deleted the feat/shares-allocation branch September 27, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jean-Grimal Jean-Grimal Jean-Grimal approved these changes

@Rubilmax Rubilmax Rubilmax approved these changes

Assignees

@MerlinEgalite MerlinEgalite

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reallocate does not update idle MarketAllocation could have a shares field
3 participants
@MerlinEgalite @Rubilmax @Jean-Grimal