refactor(sig-utils): simplify contract #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/forge/helpers/SigUtils.sol
Outdated
| // computes the hash of the fully encoded EIP-712 message for the domain, which can be used to recover the signer | ||
| function getTypedDataHash(Permit memory _permit) public view returns (bytes32) { | ||
| return keccak256(abi.encodePacked("\x19\x01", DOMAIN_SEPARATOR, getStructHash(_permit))); | ||
| function toTypedDataHash(Permit memory permit) public view returns (bytes32) { |
There was a problem hiding this comment.
do we really want the same name? it's not returning the name result
There was a problem hiding this comment.
It does return the same result, but it doesn't take the same input parameters
I think it's fine, given that Solidity will infer the function based on input parameters
Jean-Grimal
reviewed
Sep 25, 2023
Jean-Grimal
approved these changes
Sep 25, 2023
MerlinEgalite
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ECDSA.toTypedDataHash#105