Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON version #4

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

scruffian
Copy link

@scruffian scruffian commented Feb 5, 2020

This adds a JSON version of the text for use in JS bibles like javascripture.org. To test, run python main.py in the code directory.

There are some syntax errors, which I think are caused by this issue: #3

@scruffian
Copy link
Author

@emg Any thoughts on this...

@scruffian
Copy link
Author

scruffian commented Oct 24, 2020

There are some issues with this. There are some instance where the Chapter and verse breaks in this text don't line up with the numbers. This results in output like [, at the start of a verse or ][ inside a verse, both of which are invalid.

For my purposes I just fix these with a find and replace but it would be better to fix it in the code.

In addition the first verse of Mark 9 gets moved to be the last verse of Mark 8, which I also fix manually. The versification in Acts 24:2/3 is also misaligned.

Also to note that the book names used by this text don't match the OSIS standard, so if you're working with those names you need to map them like this:

1 Corinthians -> I Corinthians
2 Corinthians -> II Corinthians
1 Thessalonians -> I Thessalonians
2 Thessalonians -> II Thessalonians
1 Timothy -> I Timothy
2 Timothy -> II Timothy
1 Peter -> I Peter
2 Peter -> II Peter
1 John -> I John
2 John -> II John
3 John -> III John
Revelation -> Revelation of John

@scruffian
Copy link
Author

I added a couple of commits to address all the issues above. There is still one outstanding item which is that there seem to be some duplicated verses in the middle of John 8. I have just removed these manually from the generated file.

@scruffian
Copy link
Author

scruffian commented Nov 8, 2021

There is also an additional verse break John 1:38, which the KJV doesn't follow. I am fixing my files manually.

@scruffian
Copy link
Author

There should also be a verse break at the end of 2 Corinthians 13:12 that was missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant