-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: deployment updates. #157
Conversation
morganney
commented
Jan 5, 2024
•
edited
Loading
edited
- Added Normalize the database initialization approach #159 to resolve keeping the two scripts in sync.
- Added Redis memory overcommit warning #160 as unfinished from 122
- Closes Docker build secrets #134
- Closes Deployment and Infrastructure #122
@@ -1,6 +1,6 @@ | |||
# DNS resolution works at startup via `depends_on` for `web` service in compose.yaml. | |||
upstream api_server { | |||
server api:3000; | |||
server ${UPSTREAM_API_HOST}:3000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case I will use awsvpc
network mode (which allows containers to communicate with localhost
). This happens when running nginx as an aws copilot sidecar.
VpcSecurityGroupIds: | ||
- !Ref bmclusterDBClusterSecurityGroup | ||
ServerlessV2ScalingConfiguration: | ||
# Replace "All" below with "!Ref Env" to set different autoscaling limits per environment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notice, without following what this comment suggests then every environment is the DBMinCapacity
and DBMaxCapacity
defined for All
. In this case 2 and 8 respectively.
For now, the test
environment is more or less a staging for beta testing, UAT, etc., so it makes sense to have the same capacity expected for production.
If necessary I can set up environment level autoscaling when I need more than a staging environment, or other environments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added #159 to resolve now having two initialization scripts to keep in sync.