-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat, refactor]: add eslint import order rules, refactor import order #301
base: main
Are you sure you want to change the base?
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @morethanmin on Vercel. @morethanmin first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아아 다른 PR에 올린 커밋이 포함되었네요,, 수정해서 다시 업로드 하겠습니다! |
@morethanmin 수정했습니다 :) |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
늦게 리뷰 드려서 죄송합니다 ㅠㅠ 빌드오류가 발생해서 한번 확인 부탁드리겠습니다. 감사합니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아직 빌드오류가 발생하는 것 같아 로컬에서 한번 잡아주시면 좋을 것 같습니다.
감사합니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
네, 다시 한번 확인해보겠습니다 :) |
해당 PR 제가 이어서 작업하겠습니다 ~! |
Description
While looking at the code, I saw that the relative path and order were not organized in the import code.
So we added a function to organize the order. The following changes were made to add this function:
src/
path from being overused.src/components
->@/components
rules
to.eslintrc.json
for organize import orderbefore
after
You may be reluctant to merge because there are a lot of file changes, but the following problems can be improved with these changes:
Match code style even when file path changes
It is for this benefit that I request the change.
PR Checklist