Skip to content

Commit

Permalink
Fix indentition of CF template
Browse files Browse the repository at this point in the history
This is one of the issues, that lead to aws-samples#8
  • Loading branch information
moralesl authored Jul 27, 2023
1 parent e7718bf commit 19625b5
Showing 1 changed file with 13 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -151,17 +151,17 @@ Resources:
GroupDescription: Access to the public facing load balancer
VpcId: '{{environment.outputs.VpcId}}'
SecurityGroupIngress:
{% if 'public' == service_instance.inputs.scope %}
# Allow access to ALB from anywhere on the internet
- CidrIp: 0.0.0.0/0
IpProtocol: -1
{% else %}
# Allow access only from the VPC CIDR
- CidrIp: '{{environment.outputs.VpcCIDR}}'
IpProtocol: -1
FromPort: '{{service_instance.inputs.port}}'
ToPort: '{{service_instance.inputs.port}}'
{% endif %}
{% if 'public' == service_instance.inputs.scope %}
# Allow access to ALB from anywhere on the internet
- CidrIp: 0.0.0.0/0
IpProtocol: -1
{% else %}
# Allow access only from the VPC CIDR
- CidrIp: '{{environment.outputs.VpcCIDR}}'
IpProtocol: -1
FromPort: '{{service_instance.inputs.port}}'
ToPort: '{{service_instance.inputs.port}}'
{% endif %}

{% if 'public' == service_instance.inputs.scope %}
{% set scheme = 'internet-facing' %}
Expand All @@ -175,8 +175,8 @@ Resources:
Properties:
Scheme: '{{scheme}}'
LoadBalancerAttributes:
- Key: idle_timeout.timeout_seconds
Value: '30'
- Key: idle_timeout.timeout_seconds
Value: '30'
Subnets:
# The load balancer is placed into the public subnets, so that traffic
# from the internet can reach the load balancer directly via the internet gateway
Expand Down

0 comments on commit 19625b5

Please sign in to comment.